Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test app] Add resource package on test application #18

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jul 1, 2024

I need these Resource & Grid packages to test the other new packages. In the future, the Grid & Resource package will be migrated here.

@loic425 loic425 force-pushed the feat/add-resource-on-test-application branch 5 times, most recently from 68ebb46 to ab448d1 Compare July 1, 2024 19:53
@loic425 loic425 force-pushed the feat/add-resource-on-test-application branch from df48b01 to a97b82e Compare September 4, 2024 09:25
@loic425 loic425 changed the title Add resource package on test application [Test app] Add resource package on test application Sep 4, 2024
@loic425 loic425 force-pushed the feat/add-resource-on-test-application branch from a97b82e to 10b4dc3 Compare September 4, 2024 09:41
@loic425 loic425 force-pushed the feat/add-resource-on-test-application branch from 10b4dc3 to 7f787aa Compare September 9, 2024 12:22
src/TwigHooks/composer.json Outdated Show resolved Hide resolved
- '%kernel.project_dir%/app/Entity'

# Configure your resources
resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like it should be resources: ~ to be valid yaml, but if it works, then it works

# Configure your resources
resources:
#app.book:
#classes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented config needed?

Copy link
Member Author

@loic425 loic425 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these files are copied with Flex. I prefer keeping the default (generated one) except if we need a change.

# Enables validator auto-mapping support.
# For instance, basic validation constraints will be inferred from Doctrine's metadata.
#auto_mapping:
# App\Entity\: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented config needed?

@loic425 loic425 merged commit 56acbec into Sylius:main Sep 10, 2024
6 checks passed
@loic425 loic425 deleted the feat/add-resource-on-test-application branch September 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants