Init Admin ui package #20
Conversation
loic425
force-pushed
the
init-admin-ui
branch
4 times, most recently
from
c500762
to
4abebdf
Compare
loic425
force-pushed
the
init-admin-ui
branch
2 times, most recently
from
e7bae9d
to
9ea0f99
Compare
loic425
force-pushed
the
init-admin-ui
branch
2 times, most recently
from
8561460
to
ecf497f
Compare
| { | ||
| } | ||
|
|
||
| public function createMenu(array $options): ItemInterface |
There was a problem hiding this comment.
The default menu is empty, we have to decorate it in our end-user application.
|
|
||
| public function create(HookMetadata $hookMetadata, DataBagInterface $context, ScalarDataBagInterface $configuration, array $prefixes = []): HookableMetadata | ||
| { | ||
| $context['routing'] = $this->routing; |
There was a problem hiding this comment.
We pass the routing (pathes) configuration to all the templates.
There was a problem hiding this comment.
This following routing configuration will be passed to the template.
sylius_admin_ui:
routing:
dashboard_path: '/admin'
loic425
force-pushed
the
init-admin-ui
branch
from
656f97e
to
e65fbf2
Compare
loic425
force-pushed
the
init-admin-ui
branch
4 times, most recently
from
1e92ba1
to
eead120
Compare
loic425
force-pushed
the
init-admin-ui
branch
from
eead120
to
d77fa7c
Compare
| ) | ||
| ->addActionGroup( | ||
| ItemActionGroup::create( | ||
| // ShowAction::create(), |
There was a problem hiding this comment.
| // ShowAction::create(), |
There was a problem hiding this comment.
Yes, I'll have to build a default show template as the internal core team did in the 2.0 branch.
| ; | ||
| } | ||
|
|
||
| public function getResourceClass(): string |
There was a problem hiding this comment.
I understand it comes from grid configuration, but conceptually it's strange it's not a static method.
--- public function getResourceClass(): string
+++ public static function getResourceClass(): stringThere was a problem hiding this comment.
In the first iteration of the grid, it was a static method, but we remove that static in order to use the class model parameter from Sylius.
in this example:
%app.model.book.class%
| $services->alias(MenuBuilderInterface::class, 'sylius_admin_ui.knp.menu_builder'); | ||
|
|
||
| $services->set('sylius_admin_ui.twig_hooks.factory.hookable_metadata', RoutingHookableMetadataFactory::class) | ||
| ->decorate('twig_hooks.factory.hookable_metadata') |
There was a problem hiding this comment.
Are there plans to fix namespace for twig_hooks to sylius_twig_hooks since it starts to affect related packages.
There was a problem hiding this comment.
we have to discuss about it in the core team channel, but I agree, it's a bit risky to have no sylius prefix.
src/AdminUi/tests/Integration/DependencyInjection/SyliusAdminUiExtensionTest.php
Outdated
Show resolved
Hide resolved
| self::assertResponseIsSuccessful(); | ||
| } | ||
|
|
||
| public function testAddingBookContent(): void |
There was a problem hiding this comment.
Naming wise
public function testAddingBookContent(): void
public function testEditingBookContent(): void
is a bit confusing since it tests page existence, while name suggests actual add/edit actions.
There was a problem hiding this comment.
Yeah I know, cause for now it's just "empty", but later we'll test the content of the adding and editing page.
There was a problem hiding this comment.
public function testAddingBookContent(): void
{
$this->client->request('GET', '/admin/books/new');
self::assertResponseIsSuccessful();
// Validate Header
self::assertSelectorTextContains('h1.page-title', 'New Book');
// Validate Form
self::assertSelectorTextContains('label[for=sylius_resource_title]', 'Title');
self::assertSelectorExists('#sylius_resource_title');
self::assertSelectorTextContains('label[for=sylius_resource_authorName]', 'Author name');
self::assertSelectorExists('#sylius_resource_authorName');
// Validate Buttons
self::assertSelectorExists('[type="submit"]:contains("Create")');
self::assertSelectorExists('[data-test-cancel-changes-button]');
}
…iExtensionTest.php Co-authored-by: Dmitri Perunov <[email protected]>
No description provided.