Add redirect path Twig extension #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
redirect_path_extension
branch
4 times, most recently
from
92fcfeb
to
40a2c58
Compare
loic425
force-pushed
the
redirect_path_extension
branch
2 times, most recently
from
3917f1c
to
f56bec3
Compare
loic425
commented
Oct 2, 2024
| $request->setSession($session); | ||
| $container->get('request_stack')->push($request); | ||
|
|
||
| $this->redirectPathExtension = $container->get('sylius_twig_extra.twig.extension.redirect_path'); |
There was a problem hiding this comment.
This setup is extracted from Sylius Ui Bundle
loic425
commented
Oct 2, 2024
|
|
||
| public function testItReturnsGivenPathIfRouteHasSomeMoreConfiguration(): void | ||
| { | ||
| $redirectPath = $this->redirectPathExtension->generateRedirectPath('/admin/ajax/products/search'); |
There was a problem hiding this comment.
All this test case is extracted from the UIBundle, and I don't understand what's the specificity of this route. I have to ask someone at Sylius to reproduce that kind of route here.
loic425
force-pushed
the
redirect_path_extension
branch
5 times, most recently
from
cd7cc9f
to
a0777d4
Compare
loic425
force-pushed
the
redirect_path_extension
branch
from
a0777d4
to
a65d35b
Compare
|
I think that will be better to implement this TwigExtension on AdminUi.... cause TwigExtra is a more generic package, not related to grid, resource etc... |
|
Replaced by #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.