Talk with multiple speakers #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Oct 2, 2024
loic425
commented
loic425
force-pushed
the
talk-with-multiple-speakers
branch
from
683bb0b
to
9d88bb6
Compare
loic425
force-pushed
the
talk-with-multiple-speakers
branch
from
9d88bb6
to
fc9c0bf
Compare
diimpp
approved these changes
Oct 2, 2024
| @@ -49,19 +52,18 @@ class Talk implements ResourceInterface | |||
| private ?int $id = null; | |||
|
|
|||
| #[ORM\Column(length: 255)] | |||
| #[NotBlank] | |||
There was a problem hiding this comment.
--- public function setTitle(string $title): void
+++ public function setTitle(?string $title): void| ->add('conference', EntityType::class, [ | ||
| 'class' => Conference::class, | ||
| 'choice_label' => 'name', | ||
| 'placeholder' => 'Select a conference', |
There was a problem hiding this comment.
Suggested change
| 'placeholder' => 'Select a conference', | |
| 'placeholder' => 'app.form.talk.conference.placeholder', |
| 'allow_add' => true, | ||
| 'allow_delete' => true, | ||
| 'by_reference' => false, | ||
| 'label' => 'app.ui.speakers', |
There was a problem hiding this comment.
Suggested change
| 'label' => 'app.ui.speakers', | |
| 'label' => 'app.form.talk.speakers', |
Co-authored-by: Dmitri Perunov <[email protected]>
loic425
force-pushed
the
talk-with-multiple-speakers
branch
from
dc88740
to
335a3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.