Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestApp] Fix validation #80

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[TestApp] Fix validation #80

merged 1 commit into from
Oct 2, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 2, 2024

No description provided.

@@ -37,6 +37,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
])
->add('track', EnumType::class, [
'class' => Track::class,
'placeholder' => 'Select a track',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'placeholder' => 'Select a track',
'placeholder' => 'app.form.talk.track.placeholder',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer app.ui.select_a_track, personally.

@loic425 loic425 merged commit e8340d1 into Sylius:main Oct 2, 2024
6 checks passed
@loic425 loic425 deleted the fix/test-app-validation branch October 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants