Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cancel button on creation page #88

Merged

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 4, 2024

No description provided.

// 'cancel' => [
// 'template' => '@SyliusBootstrapAdminUi/shared/crud/common/content/header/title_block/actions/cancel.html.twig',
// ],
'cancel' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancel.html.twig has some commented code in it -- can it be cleanup in this PR?

{#{% set index_url = sylius_generate_redirect_path(app.request.headers.get('referer')|default(path(#}
{# configuration.vars.index.route.name|default(configuration.getRouteName('index')),#}
{# configuration.vars.index.route.parameters|default(configuration.vars.route.parameters|default({}))#}
{#))) %}#}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, done in another PR.

@loic425 loic425 merged commit 2a54c88 into Sylius:main Oct 4, 2024
6 checks passed
@loic425 loic425 deleted the add-missing-cancel-button-on-create-page branch October 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants