[TwigExtra] Rename sort by Twig extension #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
commented
Oct 5, 2024
| @@ -23,6 +23,7 @@ class SortByExtension extends AbstractExtension | |||
| public function getFilters(): array | |||
| { | |||
| return [ | |||
| new TwigFilter('sylius_sort_by', [$this, 'sortBy']), | |||
| new TwigFilter('sort_by', [$this, 'sortBy']), | |||
There was a problem hiding this comment.
I keep the "sort_by" function to make the build work (yeah, we still have an issue, I need some help from Monorepo experts).
I will change our usage in BootstrapAdminUi template(s) and remove it just after.
loic425
changed the title
GSadee
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.