Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Azure client demo #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Azure client demo #322

wants to merge 2 commits into from

Conversation

fm1320
Copy link
Contributor

@fm1320 fm1320 commented Jan 24, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@fm1320 fm1320 force-pushed the azure-client-demo branch from e77462e to f381e91 Compare January 24, 2025 08:29
@fm1320 fm1320 marked this pull request as ready for review January 27, 2025 11:03
liyin2015
liyin2015 reviewed Jan 27, 2025
View reviewed changes
examples/README.md
@@ -0,0 +1,89 @@
# Azure AI Client Example

This example demonstrates how to use the AdalFlow Azure AI client with both API key and Azure AD authentication methods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these examples to tutorials. and use rst

liyin2015
liyin2015 reviewed Jan 27, 2025
View reviewed changes
adalflow/adalflow/components/model_client/azureai_client.py
@@ -201,22 +146,11 @@ def __init__(
chat_completion_parser: Callable[[Completion], Any] = None,
input_type: Literal["text", "messages"] = "text",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the model_type in the client init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyin2015 liyin2015 liyin2015 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm1320 @liyin2015