-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial on working with SBOL Data Model #449
Tutorial on working with SBOL Data Model #449
Conversation
@jakebeal Could you help me with this draft? Are there any stylistic conventions I should adapt to? What content do you think this tutorial should have at the minimum? |
If you're willing, it would be great to start by just mapping the whole thing over, as is. The style that you've got is looking good in the test build: https://pysbol3--449.org.readthedocs.build/en/449/sbol_data_model.html With regards to the Finally: don't worry about the build error that's there right now -- that is a different issue that showed up on the main branch too, due to a chance in pylint standards, and I've just filed issue #450 for dealing with that. |
39c2d4e
to
4cc98e3
Compare
@jakebeal I pushed the draft of mapping the Jupyter tutorial as-is, without the Range part. Once this is merged I will make another PR just for the Range part. I will fix some small formatting issues and proof read the draft tomorrow before I remove the Draft label, but feel free to leave some remarks already. |
4cc98e3
to
9f9e41a
Compare
@jakebeal ready |
@PiotrZakrzewski thank you, this looks great to me. @jakebeal will need to review it as well. Thanks very much for the contribution! |
@jakebeal it would be nice to have you review the document before merging. If you think it's fine without review please add a comment and I'll go ahead and merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay in review. I have finally had a chance to go carefully end-to-end. I found a couple of typos, but other than that it looks goof to go!
Based on https://github.com/SynBioDex/SBOL-Notebooks/blob/main/iwbda_2023_examples.ipynb
The intention is to provide a set of concrete examples on how to create and modify different SBOL data structures.