Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply some changes from feedback #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Apply some changes from feedback #4

wants to merge 6 commits into from

Conversation

RusinovAnton
Copy link
Contributor

@RusinovAnton RusinovAnton commented Nov 22, 2019 •
edited
Loading

  • rename hitTransformer -> transformItems
  • remove direct dependency on "algoliasearch" by making user to setup search client themselves
  • update docs

@RusinovAnton RusinovAnton self-assigned this Nov 22, 2019
@RusinovAnton RusinovAnton requested a review from a team November 22, 2019 08:43
@RusinovAnton RusinovAnton marked this pull request as ready for review November 22, 2019 09:25
n1stre
n1stre reviewed Nov 25, 2019
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
n1stre
n1stre reviewed Nov 25, 2019
View reviewed changes
src/index.js
onSelect = noop,
render,
searchClient,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe throw an error to let the user know that searchClient is required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1stre n1stre n1stre approved these changes

Assignees

@RusinovAnton RusinovAnton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RusinovAnton @n1stre