-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mustache to dev env #5819
Add mustache to dev env #5819
Conversation
…PPORTED LANGUAGES (and make it easier)
TBH there is this still the documentation which could be added about the "how to use it". |
- avoid too long RUN command (max length is 1024 chars) - add zip package to dev env.
@smaarn I had to break the identation to limit the single RUN command to install packages. and added zip package for a future removement of native/zip... @th0ma7, @publicarray, @mreid-tt can you have a second look on the wizard generation from templates? |
- group is user (not users)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smaarn
but due to the sudo file error (fixed here) this did not work in spksrc containers on my newer dev machine with debian bookworm. |
I reworked to add "native" variables usable in switches:
This allows to tailor templates depending on the DSM version (without even using shell scripts !) |
@smaarn, I see the wizards in cops and I like them. I'd like to incorporate in the next update to owncloud. Will the template also work for I also note you introduced a new variable EDIT: I've tried a build for owncloud using mustache for wizards however no files were generated as part of #5912. Can you help review where I may have gone wrong? |
Description
mustache is a very simple template language which could be used to easily generate internationalized wizards.
This is an attempt to integrate it in the dev environment and would be a prerequisite for #5817
Homepage: https://mustache.github.io/
Checklist
Type of change