Add Battery level pop-up 🔋🪫 #3310
Open
+341
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes only when necessary.
…tialBatteryChange method for updates, and improved battery display rendering in session view.
…clarity, improved comments, and ensured consistent formatting in the battery icon rendering logic.
…tes only when necessary.
m-m-adams
reviewed
Feb 1, 2025
m0nkmaster
changed the title
- Put all battery-related logic into the PowerManager class for better encapsulation and maintainability. - Changed message to a popup to display battery status
|
It's now working as I would want; as a pop-up. The trigger for this is shift and cross-screen, which I don't think is used elsewhere. Just got to add documentation and do a bit more testing. Happy for anyone else to give it a test drive. |
m0nkmaster
changed the title
m0nkmaster
changed the title
|
Could you put it in the menu somewhere as well? We want to make everything findable without using shortcuts |
| #include "storage/storage_manager.h" | ||
| #include "system/power_manager.h" | ||
| #include "util/cfunctions.h" | ||
| #include "util/functions.h" | ||
|
|
There was a problem hiding this comment.
No newline here please, it's affecting how the includes are sorted and making the change bigger than it should be
stellar-aria
requested changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Battery Health Pop-up and Power Management Improvements
Adds a new feature to display battery health pop-up on the OLED display and refactors the power management system for improved functionality and maintainability.
Key Changes:
Battery Health Pop-up:
SHIFT+CROSS SCREEN.Power Management Refactor:
PowerManagerclass to handle power-related functionalities.PowerManager.CRITICAL,WARNING,HEALTHY, andFULLstates.Code Cleanup:
deluge.cpp.Documentation Updates:
CHANGELOG.mdandcommunity_features.mdto reflect the new battery health pop-up feature.Follows this discussion:
#2991