Favourites Feature #3391
Favourites Feature #3391
Conversation
Main functionality working for SYNTS and KITS Open Issues: - Initial Loading messed up - SONGS not working - Sample Browser not working
Todo: - Testing - Remove Debug Comments - Formating
|
I think something worth considering is whether to make the favourites recallable through Program Change messages. I could see a purpose for it but I might be alone in that. Each group of 16 would be a sub-bank, each class would be a bank i.e. Songs on Bank 1, Synths on Bank 2, Kits on Bank 3 etc. |
|
Thanks for the suggestion. It is definitely worth considering. However, it is something that should be well thought through as programme change messages could also be used in other places. I am happy to take it on board as an idea for possible extensions. |
…DelugeFirmware into favouritesFeature
| private: | ||
| void loadFavouritesBank(); | ||
| void saveFavouriteBank() const; | ||
| std::function<void()> onUpdateCallback; |
There was a problem hiding this comment.
Have you considered any non-callback based implementations? It's a good architecture but it does make the code less beginner friendly. If you think this is the best way to go then I'm fine with it, just curious about alternatives
There was a problem hiding this comment.
i thought it was the cleanest way to update the UI, if the Model changes. But its doable without, as i now from user Actions, when the Model change and can trigger a update in the same user action. Refactored accrordingly
| void changeColour(uint8_t position, int32_t offset); | ||
| const std::string& getFavoriteFilename(uint8_t position); | ||
| static constexpr uint8_t favouriteDefaultColor = 4; | ||
| void registerCallback(std::function<void()> callback); |
There was a problem hiding this comment.
Can you add a doc comment on what the function should do?
There was a problem hiding this comment.
removed Callback
A Favourites-Feature has been added to the Load-UIs for most File-Types. The Favourites are displayed above the Keyboard and are only visible when the keyboard is shown. Favourites can be configured to either offer 16 Favourites (default), 16 Banks with 16 Favourites or be completely disabled via
SETTINGS > DEFAULTS -> UT -> KEYBOARD -> FAVOURITES.Favourites Only (16)-Mode , 16 Favourite Slots are available at the Toprow above the Keyboard.Favourites and Banks (256)-Mode, the Toprow contains 16 Banks, each with 16 Favourites displayed on the second row.Usage:
Favourites and Banks (256)-Mode)SHIFTand select a empty Favourite Slot (light blue)Favourites and Banks (256)-Mode)SHIFTand select the Favourite Slot you want to deleteFavourites and Banks (256)-Mode)SHIFTand turnVERTICAL ENCODERTip:
If you are Browsing Songs or Samples an dont want to have the Preview to hide the Keyboard on Scrolling, just press the
KEYBOARD-Button to pin the Keyboard and the Favourites.