Implement sustain and sostenuto pedals #3404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both pedals are added as unpatched params, and then handled in the individual voices. I am not entirely certain how this will interact with MPE, but i assume they arent often used much together anyway. If someone can help test this combo, please do.
Currently, the pedal states are only accessible in the automation view, and through midi, where the CCs 64 and 66 are used as per midi spec.
Note:
Currently, there is no existing mechanism to disable automation interpolation for some parameters. This may cause issues when automating the pedals.
Its been a while since ive looked at the deluge firmware, so I may very likely have missed something.