add missing tests

Sysix · Dec 6, 2023 · a6e6e8a · a6e6e8a
1 parent 216b627
commit a6e6e8a
Show file tree

Hide file tree

Showing 19 changed files with 241 additions and 51 deletions.
diff --git a/src/Clients/Event.php b/src/Clients/Event.php
@@ -10,8 +10,8 @@
 
 class Event extends BaseClient
 {
-    use DeleteTrait;
     use CreateTrait;
+    use DeleteTrait;
 
     protected string $resource = 'event-subscriptions';
 

diff --git a/src/Clients/Invoice.php b/src/Clients/Invoice.php
@@ -10,10 +10,10 @@
 
 class Invoice extends BaseClient
 {
+    use CreateFinalizeTrait;
     use GetTrait;
     use VoucherListTrait;
     use DocumentClientTrait;
-    use CreateFinalizeTrait;
 
     protected string $resource = 'invoices';
 

diff --git a/src/Clients/OrderConfirmation.php b/src/Clients/OrderConfirmation.php
@@ -10,9 +10,9 @@
 
 class OrderConfirmation extends BaseClient
 {
+    use CreateTrait;
     use GetTrait;
     use VoucherListTrait;
-    use CreateTrait;
     use DocumentClientTrait;
 
     protected string $resource = 'order-confirmations';

diff --git a/src/Clients/Quotation.php b/src/Clients/Quotation.php
@@ -10,10 +10,10 @@
 
 class Quotation extends BaseClient
 {
+    use CreateFinalizeTrait;
     use GetTrait;
     use VoucherListTrait;
     use DocumentClientTrait;
-    use CreateFinalizeTrait;
 
     protected string $resource = 'quotations';
 

diff --git a/src/PaginationClient.php b/src/PaginationClient.php
@@ -23,7 +23,7 @@ protected function buildQueryParams(array $params): string
     {
         $params['size'] = $this->size;
 
-        return http_build_query(array_filter($params, static fn ($value) => $value !== null));
+        return http_build_query($params);
     }
 
     public function getPage(int $page): ResponseInterface

diff --git a/tests/Clients/ContactTest.php b/tests/Clients/ContactTest.php
@@ -23,6 +23,22 @@ public function testGetPage(): void
         );
     }
 
+    public function testGetPageWithFilters(): void
+    {
+        [$api, $client] = $this->createClientMockObject(Contact::class);
+
+        $client->number = 12345;
+        $client->customer = true;
+        $client->vendor = false;
+
+        $client->getPage(0);
+
+        $this->assertEquals(
+            $api->apiUrl . '/v1/contacts?page=0&direction=ASC&property=name&number=12345&customer=1&vendor=0&size=100',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testCreate(): void
     {
         [$api, $client] = $this->createClientMockObject(Contact::class);

diff --git a/tests/Clients/CreditNoteTest.php b/tests/Clients/CreditNoteTest.php
@@ -5,10 +5,26 @@
 use GuzzleHttp\Psr7\Response;
 use Psr\Http\Message\ResponseInterface;
 use Sysix\LexOffice\Clients\CreditNote;
+use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
 class CreditNoteTest extends TestClient
 {
+    public function testGet(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(CreditNote::class);
+
+        $response = $stub->get('resource-id');
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/credit-notes/resource-id',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testCreate(): void
     {
         [$api, $stub] = $this->createClientMockObject(CreditNote::class);
@@ -26,6 +42,40 @@ public function testCreate(): void
         );
     }
 
+    public function testCreateFinalized(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(CreditNote::class);
+
+        $response = $stub->create([
+            'version' => 0
+        ], true);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('POST', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/credit-notes?finalize=true',
+            $api->request->getUri()->__toString()
+        );
+    }
+
+    public function testGetPage(): void
+    {
+        $this->expectDeprecationV1Warning('getPage');
+
+        [$api, $stub] = $this->createClientMockObject(CreditNote::class);
+
+        $response = $stub->getPage(0);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=creditnote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGetAll(): void
     {
         $this->expectDeprecationV1Warning('getAll');
@@ -46,6 +96,16 @@ public function testGetAll(): void
         );
     }
 
+    public function testGetVoucherListClient(): void
+    {
+        [, $stub] = $this->createClientMockObject(CreditNote::class);
+
+        $client = $stub->getVoucherListClient();
+
+        $this->assertInstanceOf(VoucherList::class, $client);
+    }
+
+
     public function testDocument(): void
     {
         [$api, $stub] = $this->createClientMockObject(CreditNote::class);

diff --git a/tests/Clients/DownPaymentInvoiceTest.php b/tests/Clients/DownPaymentInvoiceTest.php
@@ -3,12 +3,28 @@
 namespace Sysix\LexOffice\Tests\Clients;
 
 use Psr\Http\Message\ResponseInterface;
-use Sysix\LexOffice\Clients\DownPaymentInvoice;
 use GuzzleHttp\Psr7\Response;
+use Sysix\LexOffice\Clients\DownPaymentInvoice;
+use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
 class DownPaymentInvoiceTest extends TestClient
 {
+    public function testGet(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(DownPaymentInvoice::class);
+
+        $response = $stub->get('resource-id');
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/down-payment-invoices/resource-id',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGetAll(): void
     {
         $this->expectDeprecationV1Warning('getAll');
@@ -29,6 +45,15 @@ public function testGetAll(): void
         );
     }
 
+    public function testGetVoucherListClient(): void
+    {
+        [, $stub] = $this->createClientMockObject(DownPaymentInvoice::class);
+
+        $client = $stub->getVoucherListClient();
+
+        $this->assertInstanceOf(VoucherList::class, $client);
+    }
+
     public function testDocument(): void
     {
         [$api, $stub] = $this->createClientMockObject(DownPaymentInvoice::class);

diff --git a/tests/Clients/EventTest.php b/tests/Clients/EventTest.php
@@ -26,34 +26,34 @@ public function testCreate(): void
         );
     }
 
-    public function testGetAll(): void
+    public function testDelete(): void
     {
         [$api, $stub] = $this->createClientMockObject(Event::class);
 
-        $response = $stub->getAll();
+        $response = $stub->delete('resource-id');
 
         $this->assertInstanceOf(ResponseInterface::class, $response);
 
-        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals('DELETE', $api->request->getMethod());
         $this->assertEquals(
-            $api->apiUrl . '/v1/event-subscriptions',
+            $api->apiUrl . '/v1/event-subscriptions/resource-id',
             $api->request->getUri()->__toString()
-        );
+        );    
     }
 
-    public function testDelete(): void
+    public function testGetAll(): void
     {
         [$api, $stub] = $this->createClientMockObject(Event::class);
 
-        $response = $stub->delete('resource-id');
+        $response = $stub->getAll();
 
         $this->assertInstanceOf(ResponseInterface::class, $response);
 
-        $this->assertEquals('DELETE', $api->request->getMethod());
+        $this->assertEquals('GET', $api->request->getMethod());
         $this->assertEquals(
-            $api->apiUrl . '/v1/event-subscriptions/resource-id',
+            $api->apiUrl . '/v1/event-subscriptions',
             $api->request->getUri()->__toString()
-        );    
+        );
     }
 
 }
diff --git a/tests/Clients/FileTest.php b/tests/Clients/FileTest.php
@@ -9,6 +9,21 @@
 
 class FileTest extends TestClient
 {
+    public function testGet(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(File::class);
+
+        $response = $stub->get('resource-id');
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/files/resource-id',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testUploadNotSupportedExtension(): void
     {
         $this->expectException(LexOfficeApiException::class);
@@ -83,19 +98,4 @@ public function testUploadSuccess(): void
             $api->request->getHeaderLine('Content-Type')
         );
     }
-
-    public function testGet(): void
-    {
-        [$api, $stub] = $this->createClientMockObject(File::class);
-
-        $response = $stub->get('resource-id');
-
-        $this->assertInstanceOf(ResponseInterface::class, $response);
-
-        $this->assertEquals('GET', $api->request->getMethod());
-        $this->assertEquals(
-            $api->apiUrl . '/v1/files/resource-id',
-            $api->request->getUri()->__toString()
-        );
-    }
 }
diff --git a/tests/Clients/InvoiceTest.php b/tests/Clients/InvoiceTest.php
@@ -27,6 +27,23 @@ public function testCreate(): void
         );
     }
 
+    public function testCreateFinalized(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(Invoice::class);
+
+        $response = $stub->create([
+            'version' => 0
+        ], true);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('POST', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/invoices?finalize=true',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGet(): void
     {
         [$api, $stub] = $this->createClientMockObject(Invoice::class);
@@ -42,6 +59,23 @@ public function testGet(): void
         );
     }
 
+    public function testPage(): void
+    {
+        $this->expectDeprecationV1Warning('getPage');
+
+        [$api, $stub] = $this->createClientMockObject(Invoice::class);
+
+        $response = $stub->getPage(0);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=invoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGetAll(): void
     {
         $this->expectDeprecationV1Warning('getAll');

diff --git a/tests/Clients/OrderConfirmationTest.php b/tests/Clients/OrderConfirmationTest.php
@@ -42,6 +42,23 @@ public function testGet(): void
         );
     }
 
+    public function testGetPage(): void
+    {
+        $this->expectDeprecationV1Warning('getPage');
+
+        [$api, $stub] = $this->createClientMockObject(OrderConfirmation::class);
+
+        $response = $stub->getPage(0);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('GET', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=orderconfirmation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGetAll(): void
     {
         $this->expectDeprecationV1Warning('getAll');

diff --git a/tests/Clients/ProfileTest.php b/tests/Clients/ProfileTest.php
@@ -2,7 +2,6 @@
 
 namespace Sysix\LexOffice\Tests\Clients;
 
-use GuzzleHttp\Psr7\Response;
 use Psr\Http\Message\ResponseInterface;
 use Sysix\LexOffice\Clients\Profile;
 use Sysix\LexOffice\Tests\TestClient;

diff --git a/tests/Clients/QuotationTest.php b/tests/Clients/QuotationTest.php
@@ -27,6 +27,23 @@ public function testCreate(): void
         );
     }
 
+    public function testCreateFinalized(): void
+    {
+        [$api, $stub] = $this->createClientMockObject(Quotation::class);
+
+        $response = $stub->create([
+            'version' => 0
+        ], true);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $this->assertEquals('POST', $api->request->getMethod());
+        $this->assertEquals(
+            $api->apiUrl . '/v1/quotations?finalize=true',
+            $api->request->getUri()->__toString()
+        );
+    }
+
     public function testGet(): void
     {
         [$api, $stub] = $this->createClientMockObject(Quotation::class);