-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFD: Rationale for not leveraging use-package #260
Comments
Thank you for your question.
For us, at the time, we felt that was too much "magic" going on and could be difficult to understand. The code written in Crafted Emacs is intended to be simple to read, focused on "correctness" in the sense of using the appropriate APIs, and readability. We do have one macro which is a thin wrapper around the usage of either With Emacs 29 including Hope this helps answer your question! |
It does, thank you for taking the time to respond. |
Following the response to SystemCrafters#260 we add commentary as to why use-package is not leveraged.
I had a look at the suggested change in the documentation, and I do think that there are no reason to add that to |
That's fine - I offered it up to be a "good citizen" since @jeffbowman took the time with a thoughtful reply. But if it's just adding cruft to the README, then please feel free to close the PR unmerged. |
Yes, I looked at the PR. Thanks for the suggestion. I haven't merged it as I have been thinking about it from the perspective of how to handle the answer as generically as possible and not necessarily specifically about just That said there are fairly substantial changes coming to Crafted Emacs in the near future which may make this answer moot. |
Closing post v2 release, I'll leave this pinned for a while, but may remove the pin at some point in the future. |
This is a fantastic learning resource, and in general the design principles seem very sound - I love how you've explained those principles, and they're clearly visible through the code.
After reading the code and the docs, I had one lingering question: given the emphasis on Emacs built-in functionality (e.g. Eglot, soon to be part of core Emacs distribution) I wondered why you took the decision not to leverage
use-package
, especially given that it will soon be part of the Emacs core distribution. I ask, not because I am challenging the decision, but just because it would be educational to understand, and a nice addition to the docs.The text was updated successfully, but these errors were encountered: