feat:出展画面のオブジェクトロジック完成 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SatooRu65536
requested changes
Oct 22, 2024
Comment on lines
55
to
61
| <select | ||
| name="languages" | ||
| onChange={(e) => { | ||
| setLanguage(e.target.value); | ||
| setLanguageString(e.target.value); | ||
| }} | ||
| value={language} | ||
| value={languageString} | ||
| > |
There was a problem hiding this comment.
value には 言語名(JavaScript) ではなく、言語のID を渡すべき
それに合わせて setLanguageString ではなく function setLanguage(idString: string) (引数は文字列) にしたい
Comment on lines
27
to
40
| post, | ||
| tag, | ||
| language, | ||
| setCode, | ||
| setDescription, | ||
| setLangId, | ||
| setTitle, | ||
| setUserUid, | ||
| setTags, | ||
| submit, | ||
| tagString, | ||
| setTagString, | ||
| languageString, | ||
| setLanguageString, |
There was a problem hiding this comment.
ここら辺全てちゃんと使ってあげて
setLanguageString 等の不要なもの(後述)もあるから、それは渡さない
(そもそも関数自体が不要なものもあるかも)
| </div> | ||
| </div> | ||
| <div className={styles.codeArea}> | ||
| <p>Kuso Code</p> | ||
| <textarea name="code">{code}</textarea> | ||
| <textarea name="code">{post.code}</textarea> |
feat:languageの入力をID管理に変更
SatooRu65536
approved these changes
Oct 29, 2024
評価画面を作った
- em→pxに単位を変更 - コンポーネントに margin をもたせなくした - 画像をつかめないようにした
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#11
説明
Postオブジェクトを作成し、そこにsetできる関数を作成し、PostPageLogicでreturnをしている。
現在の動作 (更新前)
ロジックが何もない状態
新しい動作 (更新後)
PostPageLogicでpost{title,descriptiona,tags,code}とそれぞれの要素を追加するset関数をreturnしている
追加情報