-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TA-Lib binary installed in virtualenv. #75
base: master
Are you sure you want to change the base?
Conversation
@@ -61,6 +64,12 @@ | |||
) | |||
ext_modules.append(ext) | |||
|
|||
# Hack to install ta-lib library loading into virtualenv | |||
def install_virtualenv_lib_loader(): | |||
with open(os.getenv('VIRTUAL_ENV', './venv') + '/bin/activate', 'a') as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this should check for exists first?
activate = os.getenv('VIRTUAL_ENV', './venv') + '/bin/activate'
if os.path.exists(activate):
with open(activate) as f:
f.write("\nexport LD_LIBRARY_PATH=$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH\n")
I have not used virtual env much, but is $VIRTUAL_ENV/lib
a standard location for loading libraries, or a workaround for talib
? Also, is $VIRTUAL_ENV/bin/activate
a standard script that is run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to detect that we are in a virtual env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct. Such a check is necessary.
When you create a virtualenv the following standard directory structure appears (bin
, include
, lib
, local
, src
) and Python binaries and packages get installed into it thereafter. There is no standard location where you create a $VIRTUAL_ENV
, some put it in a subdirectory of their project project/venv
others directly in project project
. Nevertheless this works great for all Python-related things, you just run . venv/bin/activate
and use pip install
and other things as usual, knowing it will install everything inside the virtualenv. As far as I know the best way to detect a virtualenv is using $VIRTUAL_ENV
environment variable.
Unfortunately non-Python libraries are not handled by virtualenv at all. Nevertheless in my setups I usually install them inside the virtualenv directory (./configure --prefix=$VIRTUAL_ENV
). This way binaries get installed into ./venv/bin
and work automatically (because $PATH
is configured correctly by ./venv/bin/activate) and libraries into
./venv/lib. After adding a line such as
export LD_LIBRARY_PATH=$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH` they also work as expected.
In case this seems to you as an ugly workaround, you may want to add an option to specify a custom includes
and lib
folder to search for the TA-Lib (eg. through an environment variable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a page that talks about using LD_RUN_PATH
for this:
https://groups.google.com/forum/#!topic/python-virtualenv/-U4epR1YWFk
Also, not something I expect you to have to work on, but would be nice if it worked on Mac, Linux, and Windows like the talib
library does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, maybe it would be great if the Python package would also include (or download) and compile the ta-lib
library if it is not installed system-wide? Like some packages do?
Workaround to add support for using TA-Lib binary libraries installed inside the virtualenv directory (eg
./venv/lib
).