Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some feature to Palette Dialog #327

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

owomomo
Copy link
Contributor

@owomomo owomomo commented Feb 10, 2021

Add palette preview to the Palette Dialog, you can click on the palette to customize the color and save it as a palette file.

2. Fix Debugger line height mismatch of IDA font on some systems, measure the mouse position by the actual line height in Rich Edit control rather than directly calculate it by the font height.
3. Detail.
fixed copypaste bug in cdlogger introduced in TASEmulators#310 merge
@vadosnaprimer
Copy link

Almost forgot about this! Can you add the Reset button to restore defaults?

@vadosnaprimer
Copy link

@owomomo hello?

@ClusterM
Copy link
Collaborator

ClusterM commented Jun 10, 2021

I resolved conflicts but it still lacks some features:

  • Reset button as mentioned by @vadosnaprimer.
  • fceux has 512 color palette support, what about it? Your new dialog allows you to edit only the first 64. Check RP2C03.pal for example, it contains 512 colors.

Also, why your pull request contains also many other changes? Can you describe your changes in the memory watch window?

@g0me3
Copy link
Contributor

g0me3 commented Jun 10, 2021

palette must be store all palette versions for all emphasis bits combinations. 64x8=512

@vadosnaprimer
Copy link

palette must be store all palette versions for all emphasis bits combinations. 64x8=512

At least optionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants