Fix build against x265 build 214 and above #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a perfect check, since the commit in the x265 repo that introduces it doesn't bump the X265_BUILD constant like it probably should have. There's still a range of x265 commits from 2024-10-04 to 2024-11-12 where fceux will not build against the development version of x265. If that's the case, just update to the latest x265. Research shows: https://bitbucket.org/multicoreware/x265_git@c8c9d22075b26aa279b4d634c61889ca3d49656e: - X265_BUILD: 209 -> 210 - MAX_SCALABLE_LAYERS: undefined https://bitbucket.org/multicoreware/x265_git@c69c113960834400545bc4bce2830ff51dcb86b3: - API change introduced; workaround needed - X265_BUILD: 210 - MAX_SCALABLE_LAYERS: defined https://bitbucket.org/multicoreware/x265_git@78e5b703b186fe184bf91bb37df82f64059b3f61: - API change reverted; using our workaround now breaks the fceux build - X265_BUILD: 213 - MAX_SCALABLE_LAYERS: still defined https://bitbucket.org/multicoreware/x265_git@451add89e81d45134b9d41168ceeb5516bf62d0b: - X265_BUILD: 213 -> 214 - MAX_SCALABLE_LAYERS: still defined - Using our workaround still breaks the fceux build
h3xx
changed the title
h3xx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that our workaround to call the x265 API was breaking the build, so I apply it more judiciously based on research into changes to the x265 codebase.
The current workaround breaks when building against x265 version 214 and above, and even some development versions of 213.
It's still not a perfect check. There's still a range of x265 commits from 2024-10-04 to 2024-11-12 where fceux will not build against the development version of x265. If that's the case, just update to the latest x265.
I don't believe there can be a perfect check because the commit in the x265 repo that introduces the API change we're working around doesn't bump the X265_BUILD constant like it probably should have. The revert ALSO doesn't bump it, so we have to do what we can here.
Research shows:
https://bitbucket.org/multicoreware/x265_git/commits/c8c9d22075b26aa279b4d634c61889ca3d49656e:
https://bitbucket.org/multicoreware/x265_git/commits/c69c113960834400545bc4bce2830ff51dcb86b3:
https://bitbucket.org/multicoreware/x265_git/commits/78e5b703b186fe184bf91bb37df82f64059b3f61:
https://bitbucket.org/multicoreware/x265_git/commits/451add89e81d45134b9d41168ceeb5516bf62d0b: