Kotlin validate submission pex #1234
Conversation
blackgirlbytes
requested review from
dayhaysoos,
angiejones,
EbonyLouis and
leordev
as code owners
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -71,6 +73,7 @@ import { PresentationExchange } from '@web5/credentials'; | |||
| code: ` | |||
| import web5.sdk.credentials.PresentationExchange | |||
| import web5.sdk.credentials.VerifiablePresentation | |||
| import web5.sdk.credentials.model.PresentationSubmission | |||
There was a problem hiding this comment.
I know I already included import web5.sdk.credentials.model.*, but for some strange reason that doesn't import PresentationSubmission, so that needs to be imported separately.
There was a problem hiding this comment.
@nitro-neal any thoughts or advice on why I have to import web5.sdk.credentials.model.PresentationSubmission if I'm doing import web5.sdk.credentials.model.*
There was a problem hiding this comment.
That is pretty strange, could be ide or linter problem.
Does PresentationDefinition work with *?
Its probably better to import them individually instead of using * to be more explicit and not import unnecessary things, but yea is strange. I'll see if it happens on my end
blackgirlbytes
added
the
documentation
site/docs/web5/build/verifiable-credentials/presentation-exchange.mdx
Outdated
Show resolved
Hide resolved
| { content: 'Once the [Presentation](/docs/glossary#verifiable-presentation) is error-free and has passed the validation checks, you can submit the Verifiable Presentation by providing the lender with the `presentation` JSON object:', snippetContent: validVerifiablePresentationForPex, language: 'JavaScript'}, | ||
| { content: 'After successfully creating the [Presentation](/docs/glossary#verifiable-presentation) using `VerifiablePresentation.create()`, and ensuring it is error-free and has passed all validation checks, you can submit the Verifiable Presentation by providing the lender with the `mappedPresentationSubmission` object:', snippetContent: validVerifiablePresentationForPexKt, language: 'Kotlin'}, | ||
| { | ||
| content: 'Once the [Presentation](/docs/glossary#verifiable-presentation) is error-free and has passed the validation checks, you can submit the Verifiable Presentation by providing the lender with the `presentation` JSON object:', |
There was a problem hiding this comment.
For JS, why aren't we signing and returning the JWT like we're doing in Kotlin?
There was a problem hiding this comment.
that's not available yet. I'm still waiting for that to be merged then released decentralized-identity/web5-js#382
…nge.mdx Co-authored-by: Angie Jones <[email protected]>
What type of PR is this? (check all applicable)
Description
This PR adds the Kotlin code snippets for validateSubmission(). It also clarifies why we're creating a VP after creating a Presentation from Credentials. Eventually the JS will match this logic, but the SDK code is not merged yet.
Related Tickets & Documents
Resolves #
Added code snippets?
Added tests?
Added to documentation?