fix: typealias case issues in icons and urls #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniseli
reviewed
Oct 17, 2024
Comment on lines
+28
to
+32
| const fuseOptions = { | ||
| keys: ['title', { name: 'subtitle', weight: 1 }], | ||
| minMatchCharLength: 2, | ||
| fieldNormWeight: 2, | ||
| } |
There was a problem hiding this comment.
Really nitty optimization but we could pull this out of the function/component now that it's just a constant to avoid it getting reinstantiated every call
There was a problem hiding this comment.
Yeah we probably have a few places like this 😬
deniseli
reviewed
Oct 17, 2024
|
|
||
| useEffect(() => { | ||
| if (query === '') { | ||
| setFilteredItems([]) | ||
| } else { | ||
| const results = fuse.search(query).map((result) => result.item) | ||
| setFilteredItems(results) | ||
|
|
||
| // only show first 25 results |
deniseli
reviewed
Oct 17, 2024
|
|
||
| const normalizedDeclCase = declCase?.toLowerCase() | ||
| if (!normalizedDeclCase || !declIcons[normalizedDeclCase]) { | ||
| console.warn(`No icon for decl case: ${declCase}`) |
There was a problem hiding this comment.
Ah this is way better! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandPalleteerroring whentypeAliasis used since we hadtypealiasin the icons listmodule/typealias/declNamein them vs.module/typeAlias/declNameCommandPalletesearching/filtering.See also #3146