feat: timeline service keeps events in memory #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/timeline-in-memory
branch
from
6b390a7 to
3d8331b
Compare
matt2e
commented
Dec 4, 2024
| EventEntry entry = 3; | ||
| } | ||
|
|
||
| message EventEntry { |
There was a problem hiding this comment.
EventEntry was created just so we can reuse the sumtype within Event and CreateEvent.
The extra level of wrapping is ugly everywhere else though...
There was a problem hiding this comment.
I suppose I can just repeat the oneof in both places and it'd make it a lot nicer to deal with events everywhere (the 99% case)
alecthomas
reviewed
Dec 4, 2024
| Module: event.DestVerb.Module, | ||
| Name: event.DestVerb.Name, | ||
| Entry: &pbtimeline.EventEntry{ | ||
| Entry: &pbtimeline.EventEntry_Call{ |
There was a problem hiding this comment.
What's up with the nesting?
matt2e
force-pushed
the
matt2e/timeline-in-memory
branch
from
46a4d29 to
330ca7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3626
Very simple implementation to be begin with.
Allows: