Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily expose access to local ProfileManager through web5.techPreview.profileManager #155

Closed
wants to merge 4 commits into from

Conversation

mistermoe
Copy link
Member

enables the ability to import/export profiles that will change once future changes land

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #155 (3f5d2c2) into main (2854581) will decrease coverage by 0.04%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   82.28%   82.25%   -0.04%     
==========================================
  Files          68       68              
  Lines        6814     6824      +10     
  Branches      566      566              
==========================================
+ Hits         5607     5613       +6     
- Misses       1205     1209       +4     
  Partials        2        2              
Components Coverage Δ
common 100.00% <ø> (ø)
credentials 0.00% <ø> (ø)
crypto 95.24% <ø> (ø)
dids 50.20% <ø> (ø)
web5 81.38% <58.33%> (-0.17%) ⬇️
web5-agent 0.00% <ø> (ø)
web5-proxy-agent 0.00% <ø> (ø)
web5-user-agent 79.60% <ø> (ø)

@frankhinek frankhinek changed the title Temporarily expose access to local user-agent through web5.techPreview.userAgent Temporarily expose access to local ProfileManager through web5.techPreview.profileManager Jul 18, 2023
Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the title since the proposal is to expose the ProfileManager instance and not the user agent.

This approach is not ideal but best we can do until refactored agent approach is ready for PR. Getting close.

@frankhinek frankhinek mentioned this pull request Aug 21, 2023
@frankhinek
Copy link
Contributor

Addressed in PR #168

@frankhinek frankhinek closed this Aug 21, 2023
@frankhinek frankhinek deleted the techpreview-agent branch August 21, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants