Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WorkerLocationGenerator.html #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create WorkerLocationGenerator.html #45

wants to merge 2 commits into from

Conversation

tcoliver
Copy link

tl;dr - I made a GUI to get worker location coordinates.

This Location Generator is a modified version of the this one taken from bunzosteele/PokeWatch.

I made a few changes/upgrades so that users can graphically draw their areas to be scanned. The user begins by right clicking on the map and selecting "Add Area." The areas which are created are both resizable and removable. Once the user is satisfied with their locations, he/she can right click and copy those locations to the clipboard in a format that can be directly pasted into the config.json file.

As with your other two maps, the user is required to enter their own google maps API key and can select a start location if they wish.

Here's a screenshot:

screenshot

@imatimba
Copy link

This is great! Thanks.

@Zentriert
Copy link

This is amazing! I can't thank you enough, sincerely. I wish I had it the other night when I was making like ten boxes using latlong.net lol. So much faster!

Much appreciate 👍

@RedSparr0w
Copy link

RedSparr0w commented Aug 24, 2016

Was about to do this, then saw your PR XD.

west: Lng
},
map: map,
editable: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Allow draggable

editable: true,
draggable: true

Copy link
Author

@tcoliver tcoliver Aug 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I tried that...but when I allowed draggable it broke the delete function for some reason.

When the file was first open it would work perfectly, but after deleting an area all of the remaining areas would become non-draggable.

BTW, your work on the ConfigGenerator over at /bunzosteele/PokeWatch is impressive. I'm a complete novice at this, so if you can figure out what was causing the bug, I would love to make them draggable.

@RedSparr0w
Copy link

RedSparr0w commented Aug 25, 2016

Strange seems to work fine for me (Chrome v52 | Windows 10)

Which broswer did you try it on.

@tcoliver
Copy link
Author

That's interesting. I did some more testing and it seems to be a MacOS issue. I am running MacOS 10.11.5 and Chrome v52. I tried it on a Window's 7 computer and it worked fine.

So, I'm going to make the addition, as it works for most users and doesn't actually break the functionality for Mac users (it just means you can't drag any more).

Thanks for the heads up!

@RedSparr0w
Copy link

Hmm that is a very strange bug XD.
At least it works on 1 system and just reverts to as before for mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants