Skip to content

Commit

Permalink
There is no allocators for level zero in TiledArray yet
Browse files Browse the repository at this point in the history 
Signed-off-by: Joseph Schuchart <[email protected]>
  • Loading branch information
@devreal
devreal committed Nov 27, 2023
1 parent d660b07 commit 0ab8f47
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/spmm/spmm_cuda.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ struct DeviceTensor : public ttg::TTValue<DeviceTensor<_T, _Range, _Storage>>
};

using scalar_t = double;
#if defined(TTG_HAVE_CUDA) || defined(TTG_HAVE_HIPBLAS) || defined(TTG_HAVE_LEVEL_ZERO)

This comment has been minimized.

Sign in to view

Copy link
@evaleev

evaleev Nov 27, 2023

Contributor

what needs to happen to support level zero in TA?

This comment has been minimized.

Sign in to view

Copy link
@devreal

devreal Nov 27, 2023

Author Contributor

We need a pinned allocator in TiledArray. We were not able to compile on a L0 machine with the device_pinned_allocator enabled. Is there a pinned allocator for L0 that we missed?

This comment has been minimized.

Sign in to view

Copy link
@therault

therault via email Nov 27, 2023

Contributor

This comment has been minimized.

Sign in to view

Copy link
@evaleev

evaleev Nov 27, 2023

Contributor

Ugh, ugly, are we seriously supposed to have an executor for every single fn call next? ;)

Umpire only seems to have SYCL allocators, and those indeed have different signature: https://github.com/LLNL/Umpire/blob/develop/src/umpire/alloc/SyclPinnedAllocator.hpp#L31

This comment has been minimized.

Sign in to view

Copy link
@therault

therault via email Nov 27, 2023

Contributor
#if defined(TTG_HAVE_CUDA) || defined(TTG_HAVE_HIPBLAS)
using blk_t = DeviceTensor<scalar_t, btas::DEFAULT::range,
btas::mohndle<btas::varray<scalar_t, TiledArray::device_pinned_allocator<scalar_t>>,
btas::Handle::shared_ptr>>;
Expand Down

0 comments on commit 0ab8f47

Please sign in to comment.