Consolidate make_tt_tpl and make_tt #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can map make_tt_tpl onto the same mechanism we use for make_tt by adding a template template parameter that signals whether arguments are passed as tuple or unpacked. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
evaleev
reviewed
Oct 30, 2024
ttg/ttg/util/finally.h
Outdated
|
|
||
| // final_action allows you to ensure something gets run at the end of a scope | ||
| template <class F> | ||
| class final_action |
There was a problem hiding this comment.
we might want to consider something more fully featured like https://github.com/justusc/deferral
There was a problem hiding this comment.
at least let's rename to match what will eventually land in C++: https://en.cppreference.com/w/cpp/experimental/scope_exit/scope_exit
There was a problem hiding this comment.
I took the implementation from https://github.com/tandasat/ScopedResource/ and slightly adopted it.
evaleev
approved these changes
Oct 30, 2024
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
|
@evaleev I replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can map
make_tt_tplonto the same mechanism we use formake_ttby adding a template template parameter that signals whether arguments are passed as tuple or unpacked.This is an attempt to clean up the implementation and to open the door for device-support in
ttg::make_tt_tpl.