Uplynk connector: Preplay events #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
changed the title
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/events/UplynkEvent.kt
Outdated
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkConnector.kt
Outdated
Show resolved
Hide resolved
OlegRyz
force-pushed
the
feature/uplink-preplay-events
branch
from
92c0560 to
f5b0edf
Compare
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkListener.kt
Outdated
Show resolved
Hide resolved
...lynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/UplynkEventDispatcher.kt
Outdated
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkListener.kt
Show resolved
Hide resolved
...ain/java/com/theoplayer/android/connector/uplynk/internal/network/PreplayInternalResponse.kt
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/UplynkApi.kt
Outdated
Show resolved
Hide resolved
Uplynk connector could only work with a single source at a moment so we'll fail fast rather than ignore other Uplynk sources.
…than Player Error.
OlegRyz
force-pushed
the
feature/uplink-preplay-events
branch
from
aa28bd2 to
7178e9b
Compare
MattiasBuelens
requested changes
Aug 21, 2024
...ctors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/common/HttpsConnection.kt
Outdated
Show resolved
Hide resolved
Danesz
reviewed
Aug 21, 2024
|
|
||
| val newSource = source.replaceSources(source.sources.toMutableList().apply { | ||
| remove(uplynkSource) | ||
| add(0, uplynkSource.replaceSrc(response.playURL)) | ||
| add(0, uplynkSource.replaceSrc(internalResponse.playURL)) |
There was a problem hiding this comment.
unrelated to this PR, but I think here we miss the playbackUrlParameters from here that has to be appended to the final (resolved/parsed) playURL.
(maybe it is coming in the next iteration of the feature, just do not forget it :) )
There was a problem hiding this comment.
I supposed that this will be a part of the DRM task. Currently I didn't check that it could play any signed url.
hovig-theo
reviewed
Aug 22, 2024
...ectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkSsaiDescription.kt
Outdated
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkAdIntegration.kt
Outdated
Show resolved
Hide resolved
...lynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/UplynkEventDispatcher.kt
Outdated
Show resolved
Hide resolved
...tors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/PreplayResponse.kt
Show resolved
Hide resolved
...uplynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/UplynkAdIntegration.kt
Outdated
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/UplynkApi.kt
Outdated
Show resolved
Hide resolved
...ctors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/common/HttpsConnection.kt
Outdated
Show resolved
Hide resolved
hovig-theo
approved these changes
Aug 23, 2024
...uplynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/UplynkAdIntegration.kt
Show resolved
Hide resolved
Comment on lines
31
to
35
| return when { | ||
| sessionId.isBlank() -> urlList | ||
| else -> urlList.map { "$it?pbs=$sessionId" } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit-pick: this would probably read better as a regular return if..else.
MattiasBuelens
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.