Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all metadata to Conviva #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ceyhun-o
Copy link
Contributor

@ceyhun-o ceyhun-o commented Dec 4, 2024

Applying the fix for the Web connector to Android: THEOplayer/web-connectors#35

This should fix an issue where custom tags are not passed to Conviva when the same source is replayed (without resetting the source).

An example to test with:

    private fun setSource(source: Source) {
        selectedSource = source
        theoplayerView.player.source = source.sourceDescription

        convivaConnector.setContentInfo(hashMapOf(
            "Conviva.assetName" to "THEO-Test",
            "customTag1" to "customValue1",
            "customTag2" to "customValue2"
        ))
    }

After ended, call play() on the player to replay the source and check the metadata on Touchstone.

@Jeroen-Veltmans
Copy link
Contributor

On web we added that the customMetadata would be reset on a source change. As far as I can see this is not the case on Android. Don't we also want to add this here?
And if we are at it already check if iOS also needs to be updated 😛

@ceyhun-o
Copy link
Contributor Author

ceyhun-o commented Dec 4, 2024

On web we added that the customMetadata would be reset on a source change. As far as I can see this is not the case on Android. Don't we also want to add this here?

I think that was also missing indeed. I've pushed the change.

And if we are at it already check if iOS also needs to be updated 😛

This is a bit more complicated on the iOS side (see: THEOSD-14784).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants