Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for deploying pull request previews #10

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

MattiasBuelens
Copy link
Collaborator

Uses the deploy-pr-preview action to deploy to the gh-pages branch.

@MattiasBuelens MattiasBuelens requested a review from a team as a code owner March 8, 2024 15:06
Copy link
Contributor

github-actions bot commented Mar 8, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-08 16:13 UTC

@MattiasBuelens
Copy link
Collaborator Author

Hot dang, that works nicely! 😮
image

@MattiasBuelens
Copy link
Collaborator Author

Of course, the THEOplayer license is currently not valid for theoplayer.github.io... 🤦 We'll need to update that.

@MattiasBuelens
Copy link
Collaborator Author

Still not good enough. 😅

We do this in our examples:

licenseUrl: '/docs/theoplayer-license.txt',

but on the preview website, that file will be located at /documentation/pr-preview/pr-XYZ/theoplayer-license.txt instead.

Not sure how to fix that. I think I'll keep it as a known limitation for now.

@MattiasBuelens MattiasBuelens merged commit 232ff8b into main Mar 8, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the pr-preview branch March 8, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants