Bugfix/playbutton ended state #33
Conversation
| @@ -46,7 +46,7 @@ export class PlayButton extends PureComponent<PlayButtonProps, PlayButtonState> | |||
| context.player.addEventListener(PlayerEventType.SEEKING, this.onSeeking); | |||
| this.setState({ | |||
| paused: context.player.paused, | |||
| ended: context.player.currentTime === context.player.duration, | |||
| ended: (context.player.duration > 0) && (context.player.currentTime === context.player.duration), | |||
There was a problem hiding this comment.
Why does context.player.ended not work?
There was a problem hiding this comment.
Would make sense indeed. But I just noticed we don't have this on our API. We're only supporting the ENDED event but never store it as a state.
There was a problem hiding this comment.
maybe it would make sense to rely on something that's "ended" (or the property or the event), because I think on iOS we had an issue where the duration wasn't equal to the last currentTime.
Afaik it was fixed and it dispatches the ended event (and reflects it on the property too)
Otherwise, we reintroduce the same issue on the RN level.
(on the other hand, it would be nice if iOS could update the duration properly too, if possible to detect the duration change (if any))
At the very beginning of the stream, on iOS, the currentTime is 0 and without preloading so is the duration. In that case currentTime == duration which makes the playButton assume an ended state upon initialisation.