Skip to content

Commit

Permalink
Merge pull request #429 from THEOplayer/bugfix/expo_plugin
Browse files Browse the repository at this point in the history
Bugfix/expo plugin
  • Loading branch information
tvanlaerhoven authored Oct 25, 2024
2 parents cb94f55 + 8e3f343 commit 913bfb3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed an issue on Android when using Expo, where the Expo plugin would not add THEOplayer's Maven repo to the project's repositories list.

## [8.6.0] - 24-10-25

### Added
Expand Down
5 changes: 3 additions & 2 deletions app.plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,11 @@ const withAndroidTHEOplayer = (config, props) => {
const { extensions } = props | {};
config = applyAndroidExtensions(config, extensions);

// Add the localMaven repo to the project's repositories
// Add THEOplayer and local Maven repos to the project's repositories
return withProjectBuildGradle(config, (config) => {
const localMaven = 'maven { url("$rootDir/../node_modules/react-native-theoplayer/android/local") }';
config.modResults.contents = config.modResults.contents.replace(/allprojects\s*\{\s*repositories\s*\{/, `$&\n\t\t${localMaven}`);
const THEOplayerMaven = 'maven { url("https://maven.theoplayer.com/releases") }';
config.modResults.contents = config.modResults.contents.replace(/allprojects\s*\{\s*repositories\s*\{/, `$&\n\t\t${localMaven}\n\t\t${THEOplayerMaven}`);
return config;
});
};
Expand Down

0 comments on commit 913bfb3

Please sign in to comment.