Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.2.1 #232

Merged
merged 7 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.1.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [3.2.1] - 23-12-07

### Fixed

- Fixed an issue on Android where `EnterCue` and `ExitCue` text track events did not contain the `trackUid` property.

## [3.2.0] - 23-11-29

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/com/theoplayer/PlayerEventEmitter.kt
Original file line number Diff line number Diff line change
Expand Up @@ -437,14 +437,14 @@ class PlayerEventEmitter internal constructor(
}

private val onTextTrackEnterCue = EventListener<EnterCueEvent> { event ->
val payload = PayloadBuilder().textTrackCue(event.cue, null /*TODO*/).build().apply {
val payload = PayloadBuilder().textTrackCue(event.cue, event.track).build().apply {
putInt(EVENT_PROP_TYPE, TextTrackCueEventType.ENTER_CUE.type)
}
receiveEvent(EVENT_TEXTTRACK_EVENT, payload)
}

private val onTextTrackExitCue = EventListener<ExitCueEvent> { event ->
val payload = PayloadBuilder().textTrackCue(event.cue, null /*TODO*/).build().apply {
val payload = PayloadBuilder().textTrackCue(event.cue, event.track).build().apply {
putInt(EVENT_PROP_TYPE, TextTrackCueEventType.EXIT_CUE.type)
}
receiveEvent(EVENT_TEXTTRACK_EVENT, payload)
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/com/theoplayer/util/ViewResolver.kt
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class ViewResolver(private val reactContext: ReactApplicationContext) {
uiManager?.addUIBlock {
try {
onResolved(it.resolveView(tag) as ReactTHEOplayerView)
} catch (ignore: Exception) {
} catch (e: Exception) {
// The ReactTHEOplayerView instance could not be resolved: log but do not forward exception.
Log.w(TAG, "Failed to resolve ReactTHEOplayerView tag $tag")
Log.e(TAG, "Failed to resolve ReactTHEOplayerView tag $tag: $e")
onResolved(null)
}
}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-theoplayer",
"version": "3.2.0",
"version": "3.2.1",
"description": "A THEOplayer video component for react-native.",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down
Loading