Skip to content

Commit

Permalink
Remove Broker as this is the same as the SessionManager
Browse files Browse the repository at this point in the history
  • Loading branch information
rbnbtns committed Oct 24, 2024
1 parent 23330e3 commit 5c857e2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
8 changes: 3 additions & 5 deletions yospace/src/yospace/AdBreak.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { YospaceSessionManager } from "./YospaceSessionManager";

export enum ResourceType {
STATIC,
HTML,
Expand Down Expand Up @@ -75,7 +77,7 @@ export interface AdvertEventHandler {

export interface Advert extends AdvertEventHandler {
addMacroSubstitution(key: string, value: string): void;
broker: Broker;
broker: YospaceSessionManager;
getAdType(): string;
getAdVerifications(): AdVerification[];
getCompanionAdsByType(type: ResourceType): CompanionCreative[];
Expand All @@ -96,10 +98,6 @@ export interface Advert extends AdvertEventHandler {
isNonLinear(): boolean;
}

export interface Broker {
getAdBreakForAdvert(advert: Advert): AdBreak | undefined;
}

export type { Advert as AdVert };

export interface VASTProperty {
Expand Down
3 changes: 3 additions & 0 deletions yospace/src/yospace/YospaceSessionManager.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { PlayerEvent } from './PlayerEvent';
import { TimedMetadata } from './TimedMetadata';
import { AnalyticEventObserver } from './AnalyticEventObserver';
import { AdVert, AdBreak } from './AdBreak';

export enum ResultCode {
CONNECTION_ERROR = -1,
Expand Down Expand Up @@ -28,6 +29,8 @@ export type YospaceSessionManagerCreator = {
};

export interface YospaceSession {
getAdBreakForAdvert(advert: AdVert): AdBreak | undefined;

getPlaybackMode(): PlaybackMode;

getPlaybackUrl(): string;
Expand Down

0 comments on commit 5c857e2

Please sign in to comment.