Skip to content

Commit

Permalink
Merged in bugfix/redundant-emptied-listener (pull request #8)
Browse files Browse the repository at this point in the history
Bugfix/redundant emptied listener

Approved-by: Michel Roofthooft
Approved-by: Tom Van Laerhoven
  • Loading branch information
Jeroen-Veltmans committed Aug 9, 2023
2 parents 8f9813a + d8ef4d6 commit 6b54c92
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [1.1.7] - 2023-08-09

### Fixed

- Removed reporting a buffering state on getting an `emptied` event.


## [1.1.6] - 2023-07-27

### Added
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@theoplayer/conviva-connector-web",
"version": "1.1.6",
"version": "1.1.7",
"description": "A connector implementing Conviva for web.",
"main": "dist/conviva-connector.umd.js",
"repository": "https://github.com/THEOplayer/conviva-connector-web",
Expand Down
9 changes: 0 additions & 9 deletions src/integration/ConvivaHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ export class ConvivaHandler {
this.player.addEventListener('play', this.onPlay);
this.player.addEventListener('playing', this.onPlaying);
this.player.addEventListener('pause', this.onPause);
this.player.addEventListener('emptied', this.onEmptied);
this.player.addEventListener('waiting', this.onWaiting);
this.player.addEventListener('seeking', this.onSeeking);
this.player.addEventListener('seeked', this.onSeeked);
Expand All @@ -158,7 +157,6 @@ export class ConvivaHandler {
this.player.removeEventListener('play', this.onPlay);
this.player.removeEventListener('playing', this.onPlaying);
this.player.removeEventListener('pause', this.onPause);
this.player.removeEventListener('emptied', this.onEmptied);
this.player.removeEventListener('waiting', this.onWaiting);
this.player.removeEventListener('seeking', this.onSeeking);
this.player.removeEventListener('seeked', this.onSeeked);
Expand Down Expand Up @@ -251,13 +249,6 @@ export class ConvivaHandler {
this.convivaVideoAnalytics?.reportPlaybackMetric(Constants.Playback.PLAYER_STATE, Constants.PlayerState.PAUSED);
};

private readonly onEmptied = () => {
this.convivaVideoAnalytics?.reportPlaybackMetric(
Constants.Playback.PLAYER_STATE,
Constants.PlayerState.BUFFERING
);
};

private readonly onWaiting = () => {
this.convivaVideoAnalytics?.reportPlaybackMetric(
Constants.Playback.PLAYER_STATE,
Expand Down

0 comments on commit 6b54c92

Please sign in to comment.