Add destroy() method
#24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 139c137 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MattiasBuelens
force-pushed
the
feature/yospace-enable-usage-of-dvrlive-for-livestreams
branch
from
ac9ce41 to
139c137
Compare
This has already been fixed in #24. I've rebased your PR to remove those changes, and only include the |
MattiasBuelens
changed the title
destroy() method
MattiasBuelens
requested changes
May 27, 2024
| @@ -89,3 +89,10 @@ await yospaceConnector.setupYospaceSession(source, sessionProperties); | |||
| ``` | |||
|
|
|||
| Once the setup of the Yospace session is done, you can continue to use the player and the connector will handle everything related to Yospace. | |||
|
|
|||
| To shutdown the current Yospace session, use the connector's `destroy()` method. The connector automatically calls `session.shutdown()` on session initialization errors and when creating a new session. If you, however, set a non-yospace source to the player after using this connector, it is your responsibility to do this through `destroy()`. | |||
There was a problem hiding this comment.
Do we really need a new connector method for this? Can't the connector call reset() automatically, for example when THEOplayer fires a sourcechange or destroy event? 🤔
|
With #26, we will now call So I consider this to be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdatedupdateYospaceWithPlaybackPositionto report the currentTime offset wrtsession.getStreamStart()(Superseded by Offset the playback position from stream start for Yospace DVRLive sessions #23)
destroy()method to the connector, to allow users to shutdown the current yospace session. E.g. for when a non-yospace source will be set to the player. Right now this shutdown only happens when setting a new yospace source or when initialization of the session fails.