Add Yospace configuration types to connector #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 898b3e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GillesMoris-Dolby
approved these changes
Jul 31, 2024
|
Can we / do we also need to move the |
|
That's a little bit more difficult, since we actually have special logic for that in the ID3 parser of THEOplayer. Maybe another time! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
YospaceServerSideAdInsertionConfigurationis currently defined in the THEOplayer Web SDK, and imported by the Yospace connector. This is not ideal:This PR adds the
YospaceServerSideAdInsertionConfigurationtype to the Yospace Connector itself. It is currently identical to the one shipped with THEOplayer, so customers won't need to change anything in their code. However, we highly recommend updating the imports in your code to use the connector's types, in preparation of a future removal from the Web SDK.