-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nielsen dcr #45
Merged
Merged
Changes from 54 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8ff3ca1
Add tested countries
wjoosen 7fbdeb7
Load separate static queue snippet for different country configurations
wjoosen b9208da
appId placeholder string
wjoosen 8541e1b
Reference to CZ docs
wjoosen 9516b27
Rename DTVR Content Metadata
wjoosen 9352600
Add example content metadata object for CZ DCR
wjoosen 04bdf84
Add ContentMetadata types split up in generic, US and CZ specific pro…
wjoosen 1d5dc5a
Add CZ Ad metadata type
wjoosen 38c5740
Add configuration type
wjoosen 083b2ca
pass country configuration to static queue snippet loading function
wjoosen 9b1d992
store configuration parameters in handler
wjoosen 6d052ee
updateMetadata improvements
wjoosen ca2de34
introduce DCRContentMetadata field
wjoosen b6bc9a6
tweak if statement
wjoosen e81ae1a
only send onLoadMetadata with dtvr metadata if dtvr is enabled
wjoosen 059f61f
only send play event if dtvr is enabled
wjoosen 8cc288e
send loadMetadata event for DCR on first play event
wjoosen a12d29f
adjust types
wjoosen 0487a5f
separate ad metadata reporting logic for dcr and dtvr
wjoosen a95ac85
set initial adMetadata io placeholder values
wjoosen 05c7477
take first array item of filtered currentAds and add TODO note
wjoosen 50f7b9f
import
wjoosen 23cf5c7
Report playhead position
wjoosen b4a7ca4
only report playhead position when DCR is enabled
wjoosen bdae3eb
dont listen for timed metadata if DTVR is not enabled
wjoosen 0713d95
send stop event when an ad ends
wjoosen 4e67802
report end before post roll starts
wjoosen 8a9fc8e
typo
wjoosen 235f9ae
add and remove listener
wjoosen 3a7f857
rewrite
wjoosen 62a787b
only report setVolume for DTVR
wjoosen 520838c
remove comments
wjoosen 5918b31
ignore NaN duration change events
wjoosen 2447323
detect post rolls for DAI sources too
wjoosen 85b4c30
report stop if an ad was playing in the onEnd handler
wjoosen 62ef2fc
report stop on more interrupt scenarios
wjoosen 824079a
adapt build ad metadata helper to new getAdType implementation
wjoosen 2f8dec3
Add public DCR metadata types
wjoosen 5fce7b8
convert provided metadata to types imposed by nielsen dcr docs
wjoosen 66b72c5
expose updateDCRContentMetadata
wjoosen d0edda9
add configuration parameter
wjoosen 674e01a
add import
wjoosen f1cae07
edit paths
wjoosen 0e5d9bd
edit librarylocation path
wjoosen 0f55a07
edit serve script
wjoosen 84afa8d
set sessionInProgress to true regardless of DCR/DTVR config
wjoosen e3f6673
use Ad from AdBeginEvent
wjoosen 2448e81
update README
wjoosen 7f6391c
typo
wjoosen 1005a44
add necessary type exports
wjoosen 8abc60c
finish example page
wjoosen e0e5fd4
Add changeset
wjoosen f1cbb0d
edit example metadata
wjoosen ecaa04b
always include nol_c2 property
wjoosen 44bc3e5
only print logs if nol_sdkDebug === "debug"
wjoosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/nielsen-connector-web": minor | ||
--- | ||
|
||
Add DCR support (CZ and US). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,11 @@ | ||
export { NielsenConnector } from './integration/NielsenConnector'; | ||
export { NielsenOptions } from './nielsen/Types'; | ||
export { | ||
NielsenOptions, | ||
NielsenDCRContentMetadata, | ||
NielsenDCRContentMetadataCZ, | ||
NielsenDCRContentMetadataUS, | ||
NielsenConfiguration, | ||
NielsenCountry, | ||
AdLoadType, | ||
HasAds | ||
} from './nielsen/Types'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this log? Or was this for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it made sense to warn developers about the fact that not any passed metadata can be updated mid playback. I have put it behind a check for
nol_sdkDebug === "debug"
, so it only shows if logging is enabled for the Nielsen calls also.