Bugfix/missing c4 parameter #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de8e276 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wjoosen
requested review from
georgechoustoulakis,
Jeroen-Veltmans and
GillesMoris-Dolby
Jeroen-Veltmans
approved these changes
Sep 23, 2024
| * [VOD] Keep empty | ||
| * [LIVE] Pass the duration of the live broadcast in seconds | ||
| */ | ||
| c4?: string; |
There was a problem hiding this comment.
Since we have c1, c2 and now c4, is there also a c3 we should add? 😛
There was a problem hiding this comment.
😄 I thought about this too, but it seems to not be the case:
nielsen/src/nielsen/Types.ts
Outdated
| /* | ||
| * The actual duration of the live broadcast | ||
| * [VOD] Keep empty | ||
| * [LIVE] Pass the value in seconds as follows "nol_c4" : "p4, value_in_seconds" |
There was a problem hiding this comment.
Nit-pick: "p4,value_in_seconds" without the space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to add a missing parameter to the Czech main content metadata properties. This was missed in the initial release since the parameter is not mentioned in the documentation on Nielsen's Engineering Portal. It is, however, mentioned on the Admosphere documentation.