Feature/enable choosing bindings #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Camunda tests for subscribe method - Fix EthereumAdapter test
- Fix dependencies - Initial support for asynchronous errors - Fix tests
- Switch BlockchainManager to using the new mechanism - Introduce GenericAsynchronousBalException - Add test cases - Reorganize packages
- Use a dedicated final class to represent asynchronous exceptions. It encapsulates a BalException as a cause, and adds an obligatory correlation identifier. The class should be instantiated only by the blockchain manager because it knows the context + it has the correlation identifier.
- detect block gas limit reached - detect unknown account - possibly many more errors... - all use -32100 code because details are only available in a string not a code.
- if the timeout value is specified to be 0 (or was missing), it is set to Long.MAX_VALUE
- Add RESTful controller for managing endpoint binding rules at the "bindings" path
- write README.md entry
Catch all exceptions (instead of only IOException) inside the Observable that fetches Ethereum blocks (otherwise the error will not be handled and will cause a failure "missing onError bla bal")
- fix message names - fix data types - update README
Remove ProcessInstanceID from Camunda Message
|
Handled by #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows users to configure the gateway so that the output binding (i.e., the format of the SCIP reply messages) correspond to their expectations. Two output bindings are currently supported:
json-rpcandcamunda