チャット中のURL文字列をリンクに変換する #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usaturn
pushed a commit
to usaturn/udonarium
that referenced
this pull request
Mar 17, 2023
V1.10.0b1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
チャット中のURL文字列をリンクに変換する機能を実装いたしました。
それ以外の文字列は既存動作を壊さないように、全ての文字をHTML Escapeする処理を入れています。
懸念点
escapeHtmlの実装ですが、これはAngularが内部で行っている処理と同じものです。
しかしAngularがこの関数をexportしていないため、component内で再実装しています。
参考URL: https://stackoverflow.com/questions/38577347/manually-sanitize-a-string