Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with multi-word char names like Devil Jin #10

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

AbhijeetKrishnan
Copy link
Contributor

Convert character names when querying cargo (replace _ with space, convert to title case). Convert move IDs when using them in URLs by replacing spaces with _. Fixes #9

This is quite a hacky solution again, and hopefully there aren't other characters like this.

@TLNBS2405 TLNBS2405 merged commit 1535a21 into TLNBS2405:master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not link to Devil Jin's moveset
2 participants