Fix issue with move queries with * in the input not being handled correctly
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*` was previously being escaped in move input while storing in FrameDb, since it is a formatting character in Discord Markdown. However, this causes issues when attempting to recognize move input queries. The input is now stored as is, with the conversion to Discord Markdown done when the embed is being built.
|
Hey it seems like the test is failing :) can you make it work then I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. Asuka f+3* and Asuka f+3*n were not correctly retrieved with a corresponding move query due to issues with how the
*was processed for Discord Markdown.