Access wrapped members as shared object #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Port numpy_proxy class from nda
Previously member of a wrapped type were copied on access This commit introduces an option where access of wrapped members will avoid the copy at the cost of keeping the parent object alive for the full lifetime of the newly generated reference
Wentzell
force-pushed
the
DEV_wrapped_members_shared_access
branch
from
709e7a8 to
17a7bfb
Compare
Wentzell
force-pushed
the
master
branch
2 times, most recently
from
3d102a0 to
035ebff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we access a member of a wrapped class where the type of the member is itself wrapped,
we should not copy but instead provide a new reference to the member which guarantees to keep the parent object alive.