fix: BLAS batch strided needs sufficiently new MKL #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized that there are no MKL tests in the CI, because I made a mistake in the original commit, yet the CI still passed. |
|
Thank you @hmenke for adding this check. I have enabled the |
|
Do you have a reference that shows that those functions were introduced in this specific version? |
|
I just guessed, because I noticed that it was present in 2020.4 but absent in 2020.0. Unfortunately it's not mentioned in the changelog when it was introduced so I just downloaded all past version from the repo and grepped through them, see the commit message. |
First introduced in Intel MKL 2020.2 Unfortunately this is not mentioned in any changelog https://www.intel.com/content/www/us/en/developer/articles/release-notes/intel-math-kernel-library-release-notes-and-new-features.html $ curl -sSfL https://apt.repos.intel.com/mkl/dists/all/main/binary-all/Packages | awk '/^Filename/ && /intel-mkl-common-c-2020/ { print $2 }' | xargs -I{} curl -sSfLO 'https://apt.repos.intel.com/mkl/{}' $ for pkg in intel-mkl-common-c-2020*.deb; { ar x "$pkg" data.tar.xz && tar xJf data.tar.xz; } $ grep -r dgemm_batch_strided ./opt/intel/compilers_and_libraries_*/linux/mkl/include/mkl_blas.h ./opt/intel/compilers_and_libraries_2020.2.254/linux/mkl/include/mkl_blas.h:void dgemm_batch_strided(const char *transa, const char *transb, const MKL_INT *m, const MKL_INT *n, const MKL_INT *k, ./opt/intel/compilers_and_libraries_2020.3.279/linux/mkl/include/mkl_blas.h:void dgemm_batch_strided(const char *transa, const char *transb, const MKL_INT *m, const MKL_INT *n, const MKL_INT *k, ./opt/intel/compilers_and_libraries_2020.4.304/linux/mkl/include/mkl_blas.h:void dgemm_batch_strided(const char *transa, const char *transb, const MKL_INT *m, const MKL_INT *n, const MKL_INT *k,
|
Please also cherry-pick this onto 1.2.x |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.