Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accum #967

Open
wants to merge 12 commits into
base: unstable
Choose a base branch
from
Open

Accum #967

wants to merge 12 commits into from

Conversation

dominikkiese
Copy link
Contributor

Reopening of #966

@dominikkiese dominikkiese mentioned this pull request Sep 26, 2024
Closed
@Wentzell
Copy link
Member

Thank you @dominikkiese for this improvement! I pushed some simplifications in my commit ffb12cc

Can you please look into creating a test of the callback functionality?

@dominikkiese
Copy link
Contributor Author

Commit looks good to me, using nda::map with the abs_square function makes the code much more compact! I will think about a proper test.

dominikkiese and others added 12 commits December 17, 2024 11:26
@dominikkiese @Thoemi09
[stat] Add callback function to accumulator, consistently use nda::ha…
7dbe3d9 
…damard
@Wentzell @Thoemi09
[stat] Simplify accumulator callback construction, add abs_square fun…
960e06c 
…ction to simplify code
@Wentzell @Thoemi09
[stat] Callback in linear binner should be called before compression
bff5e24
@Thoemi09
Rename make_real.hpp to utils.hpp, add more utils and tests
1cb60f5
@Thoemi09
Clean up in mean_error.hpp and in the corresponding tests
023f8c4
@Thoemi09
Move lin_binning and log_binning out of detail namespace into their o…
7ee99b2 
…wn file
@Thoemi09
Clean up lin_binning.hpp and add new tests
753539a
@Thoemi09
Clean up log_binning.hpp and add new tests
1ba082b
@Thoemi09
Clean up jackknife.hpp and add new tests
10c3738
@Thoemi09
Clean up histograms.hpp/.cpp and update tests
59aaf45
@Thoemi09
Add some additional tests to triqs/stat
d13623c
@Thoemi09
Remove accumulator.hpp and various tests in triqs/stat
65e5973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parcollet parcollet Awaiting requested review from parcollet

@Wentzell Wentzell Awaiting requested review from Wentzell

@Thoemi09 Thoemi09 Awaiting requested review from Thoemi09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikkiese @Wentzell @Thoemi09