Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starr): Add CF for BBC iPlayer #1714

Merged
merged 5 commits into from
Dec 31, 2023
Merged

feat(starr): Add CF for BBC iPlayer #1714

merged 5 commits into from
Dec 31, 2023

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Dec 31, 2023 •
edited
Loading

Pull Request

Purpose

Missing streaming services BBC iPlayer in the Starr apps

Approach

Add CF for BBC iPlayer

Open Questions and Pre-Merge TODOs

  • Add CF BBC iPlayer for Sonarr.
  • Add CF BBC iPlayer for Radarr.
  • Add CF BBC iPlayer to Guides.
  • Add CF BBC iPlayer to Sonarr Collection with short description.
  • Add CF BBC iPlayer to Radarr Collection with short description.

Requirements

@TRaSH- TRaSH- requested a review from a team December 31, 2023 17:26
@TRaSH- TRaSH- marked this pull request as draft December 31, 2023 17:26
@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Dec 31, 2023
yammes08 and others added 4 commits December 31, 2023 17:38
@yammes08
Updated SQP Streaming Service Tables
a2eb214 
- Added new iPlayer streaming service to SQP streaming service tables
- Added other missing streaming services to SQP streaming service tables
- Alphabetically ordered and tidied SQP streaming service tables
@yammes08
Lint fixes
0585b8b 
- Removed multiple blank lines
@TRaSH-
Add CF BBC iPlayer to Sonarr Collection with short description.
130aeb2
@TRaSH-
Add CF BBC iPlayer to Radarr Collection with short description
998a447
@TRaSH- TRaSH- marked this pull request as ready for review December 31, 2023 18:15
@TRaSH- TRaSH- linked an issue Dec 31, 2023 that may be closed by this pull request
Feat(Starr): Add custom format for BBC iPlayer #1710
Closed
zakkarry
zakkarry approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TRaSH- TRaSH- merged commit e845690 into master Dec 31, 2023
15 checks passed
@TRaSH- TRaSH- deleted the feat/starr-add-cf-for-BBC-iPlayer branch December 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkarry zakkarry zakkarry approved these changes

Assignees
No one assigned
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(Starr): Add custom format for BBC iPlayer
3 participants
@TRaSH- @zakkarry @yammes08