Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr-name-check): integrates pr naming convention into workflow #1881

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

zakkarry
Copy link
Contributor

@zakkarry zakkarry commented Apr 13, 2024

Pull Request

Purpose

verifies that the naming conventions we use are followed for PR open/reopen/edit

TODO

  • verify that commenting works when pr title is bad
  • verify that commenting does not happen when title is good
  • verify regex edge cases?

@zakkarry zakkarry self-assigned this Apr 13, 2024
@github-actions github-actions bot added Area: github_actions Github Actions Related Area: Backend Backend Changes, not related to a specific section labels Apr 13, 2024
@zakkarry zakkarry force-pushed the pr-naming-ci branch 2 times, most recently from 32f99c4 to 90fed18 Compare April 13, 2024 17:26
@zakkarry zakkarry force-pushed the pr-naming-ci branch 8 times, most recently from 3296d31 to b749d54 Compare April 13, 2024 19:50
@zakkarry zakkarry changed the title integrates pr naming convention into workflow ci(test): integrates pr naming convention into workflow Apr 13, 2024
@zakkarry zakkarry changed the title ci(test): integrates pr naming convention into workflow integrates pr naming convention into workflow Apr 13, 2024
@zakkarry zakkarry closed this Apr 13, 2024
@zakkarry zakkarry reopened this Apr 13, 2024
@zakkarry zakkarry force-pushed the pr-naming-ci branch 2 times, most recently from 084aec0 to 21bced7 Compare April 13, 2024 20:23
@zakkarry zakkarry closed this Apr 13, 2024
@zakkarry zakkarry reopened this Apr 13, 2024
@zakkarry zakkarry closed this Apr 13, 2024
@zakkarry zakkarry reopened this Apr 13, 2024
@zakkarry zakkarry changed the title integrates pr naming convention into workflow ci(pr-title-validation): integrates pr naming convention into workflow Apr 13, 2024
@zakkarry zakkarry changed the title ci(pr-title-validation): integrates pr naming convention into workflow integrates pr naming convention into workflow Apr 14, 2024
@zakkarry zakkarry closed this Apr 14, 2024
@zakkarry zakkarry reopened this Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

@zakkarry your pull request title "integrates pr naming convention into workflow" does not conform to our naming conventions (https://www.conventionalcommits.org/en/v1.0.0/).

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>"

@zakkarry zakkarry changed the title integrates pr naming convention into workflow ci(pr-title-check): integrates pr naming convention into workflow Apr 14, 2024
@zakkarry zakkarry changed the title ci(pr-title-check): integrates pr naming convention into workflow integrates pr naming convention into workflow Apr 14, 2024
@zakkarry zakkarry closed this Apr 14, 2024
@zakkarry zakkarry reopened this Apr 14, 2024
@TRaSH-Guides TRaSH-Guides deleted a comment from github-actions bot Apr 14, 2024
Copy link
Contributor

@zakkarry your pull request title "integrates pr naming convention into workflow" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>"

@zakkarry zakkarry changed the title integrates pr naming convention into workflow ci(pr-name-check): integrates pr naming convention into workflow Apr 14, 2024
@FonduemangVI FonduemangVI self-requested a review April 15, 2024 01:14
Copy link
Contributor

@FonduemangVI FonduemangVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FonduemangVI FonduemangVI merged commit 27106e0 into master Apr 15, 2024
9 checks passed
@FonduemangVI FonduemangVI deleted the pr-naming-ci branch April 15, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: github_actions Github Actions Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants