Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(guides): fix several broken/forgotten anchors #1912

Merged
merged 1 commit into from
May 4, 2024

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented May 4, 2024

Pull Request

Purpose

fix several broken/forgotten links anchors

Approach

Noticed that some links anchors where broken/forgotten so fixed them.

Open Questions and Pre-Merge TODOs

  • Tested Locally

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related labels May 4, 2024
@TRaSH- TRaSH- requested a review from a team May 4, 2024 14:10
@zakkarry
Copy link
Contributor

zakkarry commented May 4, 2024

How did this build with broken links?

@TRaSH-
Copy link
Contributor Author

TRaSH- commented May 4, 2024

How did this build with broken links?

05/04/2024
10:40:21 AM
INFO    -  Doc file 'Downloaders/Deluge/Tips/Unraid-Mover.md' contains a link '#copy-script-to-your-preferred-location', but there is no such anchor on this page.
05/04/2024
10:40:21 AM
INFO    -  Doc file 'Downloaders/qBittorrent/Tips/How-to-run-the-unRaid-mover-for-qBittorrent.md' contains a link '#copy-script-to-your-preferred-location', but there is no such anchor on this page.
05/04/2024
10:40:21 AM
INFO    -  Doc file 'Hardlinks/How-to-setup-for/Dockstarter.md' contains a link '#qbittorent', but there is no such anchor on this page.
05/04/2024
10:40:21 AM
INFO    -  Doc file 'Sonarr/sonarr-collection-of-custom-formats.md' contains a link '#tving', but there is no such anchor on this page.

I don't know, but i noticed these errors and i was curious what the cause was

@zakkarry
Copy link
Contributor

zakkarry commented May 4, 2024

I dont think anchors count as broken links, were ALL the errors anchors? because technically speaking an anchor still links to a valid page, so that might be why....


TRaSH:
Hmm, i think you're right they are anchors and not links.


lol clicked edit not quote reply :P @TRaSH-

@TRaSH- TRaSH- changed the title chore(guides): fix several broken/forgotten links chore(guides): fix several broken/forgotten anchors May 4, 2024
@TRaSH-
Copy link
Contributor Author

TRaSH- commented May 4, 2024

well updated the PR title and the description.

@TRaSH- TRaSH- merged commit 057251a into master May 4, 2024
13 checks passed
@TRaSH- TRaSH- deleted the chore/guides-fix-several-broken/forgotten-links branch May 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related Area: Sonarr Sonarr Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants