-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(starr): New French guide #2132
fix(starr): New French guide #2132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TRaSH- Tell me if we can at least add the CF like this? So that people have access to the json
Doesn't the Radarr one need fixes also? |
I completely forgot the part about Radarr but it's fixed, I tested it locally. ( |
@NiceTSY Does the Radarr |
We can definitely add it to the Radarr FR Guide. Could you also remove the two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TRaSH-
Just checking with you if you agree on putting them into the collection of CFs (but not into the tables of the same page). If so this PR is good for me to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally, and the only error I found was something in the French anime section that would be fixed after the merge of PR #2133
Keep in mind the French language CF JSON is temp-approved and can be changed later.
Yup no problem for that ! it was seen with @NiceTSY |
* (fix) Missing french-multi-vf score for web-scene * (fix) Missing tag <sub> for FR LQ * (feat) Add Language Profile to Sonarr Collection CF * (fix) Remove special char in title for Language Original French * (fix) Update sonarr-collection-of-custom-formats * (feat) Add Language Profile to Radarr-collection-of-custom-formats * (fix) remove `:exclamation:` for web-scene * (fix) Wrong link to Sonarr-Quality-Settings-File-Size in Anime Guide * Reverted: table formatting --------- Co-authored-by: TRaSH <[email protected]>
Pull Request
Purpose
PR to fix error found in the new french guide
Edit: PR is ready to merge, need review of @NiceTSY
Requirements
TODO / Done
Not related to French Guide :