Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starr): New French guide #2132

Merged
merged 9 commits into from
Dec 1, 2024

Conversation

SeiyaGame
Copy link
Contributor

@SeiyaGame SeiyaGame commented Nov 17, 2024

Pull Request

Purpose

PR to fix error found in the new french guide

Edit: PR is ready to merge, need review of @NiceTSY

Requirements

TODO / Done

Not related to French Guide :

  • Wrong link to Sonarr-Quality-Settings-File-Size in Anime Guide

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Nov 17, 2024
@SeiyaGame SeiyaGame changed the title fix (Starr): New French guide fix (starr): New French guide Nov 17, 2024
@SeiyaGame SeiyaGame changed the title fix (starr): New French guide fix(starr): New French guide Nov 17, 2024
@SeiyaGame SeiyaGame marked this pull request as ready for review November 19, 2024 20:02
@SeiyaGame
Copy link
Contributor Author

@NiceTSY not so much fix, more on the anime part, but in progres in this PR #2133

Copy link
Contributor Author

@SeiyaGame SeiyaGame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TRaSH- Tell me if we can at least add the CF like this? So that people have access to the json

@TRaSH-
Copy link
Contributor

TRaSH- commented Nov 19, 2024

@TRaSH- Tell me if we can at least add the CF like this? So that people have access to the json

Doesn't the Radarr one need fixes also?

@github-actions github-actions bot added the Area: Radarr Radarr Related label Nov 19, 2024
@SeiyaGame
Copy link
Contributor Author

@TRaSH- Tell me if we can at least add the CF like this? So that people have access to the json

Doesn't the Radarr one need fixes also?

I completely forgot the part about Radarr but it's fixed, I tested it locally. (mkdocs serve)

@SeiyaGame
Copy link
Contributor Author

@NiceTSY Does the Radarr web-scene.json need also to be fixed or it's not used in the Radarr FR Guide ?

This line is missing :
image

@NiceTSY
Copy link
Contributor

NiceTSY commented Nov 22, 2024

@NiceTSY Does the Radarr web-scene.json need also to be fixed or it's not used in the Radarr FR Guide ?

This line is missing : image

We can definitely add it to the Radarr FR Guide. Could you also remove the two ! also from both Sonarr and Radarr for this CF?

@SeiyaGame
Copy link
Contributor Author

I removed the ! for sonarr but I didn't add a web-scene for Radarr because it doesn't work the same way.
Apparently the scene on radarr isn't even used in fallback

@NiceTSY For me it's all good
The rest of the fixes are for anime, which can be found here #2133

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TRaSH-
Just checking with you if you agree on putting them into the collection of CFs (but not into the tables of the same page). If so this PR is good for me to go.

TRaSH-
TRaSH- previously approved these changes Dec 1, 2024
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally, and the only error I found was something in the French anime section that would be fixed after the merge of PR #2133

Keep in mind the French language CF JSON is temp-approved and can be changed later.

@SeiyaGame
Copy link
Contributor Author

Keep in mind the French language CF JSON is temp-approved and can be changed later.

Yup no problem for that ! it was seen with @NiceTSY

@TRaSH- TRaSH- merged commit 3bf3213 into TRaSH-Guides:master Dec 1, 2024
11 checks passed
@SeiyaGame SeiyaGame deleted the fix/starr-french-guide-v2 branch December 1, 2024 23:42
SeiyaGame added a commit to SeiyaGame/Guides that referenced this pull request Dec 17, 2024
* (fix) Missing french-multi-vf score for web-scene

* (fix) Missing tag <sub> for FR LQ

* (feat) Add Language Profile to Sonarr Collection CF

* (fix) Remove special char in title for Language Original French

* (fix) Update sonarr-collection-of-custom-formats

* (feat) Add Language Profile to Radarr-collection-of-custom-formats

* (fix) remove `:exclamation:` for web-scene

* (fix) Wrong link to Sonarr-Quality-Settings-File-Size in Anime Guide

* Reverted: table formatting

---------

Co-authored-by: TRaSH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants